Getting started with GitHub pull requests and reviews
Brian and Aurooba walk through the process of submitting a pull request in GitHub, reviewing it, and merging it into a repository – discussing best practices and perspectives to take as the reviewer and the reviewee in an ongoing pull request. In this case, the open source project was wphelpers.dev and Brian was adding a fantastic new helper: a searchable guide to the WordPress Icon library (@wordpress/icons), which they also take a look at.
A full transcript of the episode is available on the website. Subscribe to our channel and newsletter (https://viewsource.fm/subscribe) to hear about episodes (and more) first!
The searchable icon library – https://wphelpers.dev/icons
The Post Status slack comment that prompted the creation of wphelpers.dev – https://poststatus.slack.com/archives...
@wordpress/icons repo – https://github.com/WordPress/gutenber...
@wordpress/icons visual reference – https://wordpress.github.io/gutenberg...
Netlify deploy previews – https://docs.netlify.com/site-deploys...
Netlify collaborative drawer – https://www.netlify.com/products/depl...
Brian's viral tweet thread about the searchable icon library – https://www.briancoords.com/building-...
Brian's website – https://www.briancoords.com
Aurooba's website – https://aurooba.com
00:00:00 Introduction
00:00:13 A tangent on wearing a uniform everyday
00:02:05 Recapping v1 of this episode we had already recorded
00:02:42 Getting into the topic: collaborating on GitHub
00:03:46 Introducing wphelpers.dev and how it came to be
00:05:04 How the searchable icon library guide came to be
00:06:12 The portability of Gutenberg packages
00:07:20 Walking through the searchable Icon Library
00:09:23 How wp-scripts interacts with @wordpress/icons
00:09:51 Our favourite uses for the searchable icon library
00:11:02 Diving into the pull request
00:11:41 Creating work-in-progress PRs
00:12:56 Collaborating with the deploy preview feature in Netlify
00:13:14 Getting feedback early on in the process
00:14:16 The netlify collaboration drawer
00:15:07 The ideal opening comment on a PR
00:16:27 Requesting a review in GitHub
00:16:49 Determing the right time to request a review
00:17:47 The features of an official review in GitHub
00:20:53 Making new issues from incoming feedback
00:21:27 Creating trackable history in GitHub
00:25:13 Requesting changes through reviews in GitHub
00:26:13 The code view in PRs and its features
00:27:40 GitHub reviews allow you to post your comments holistically
00:30:23 Automatic deployment with Netlify
00:31:35 Using the right tool for the situation
00:33:21 Discovering the existing icon library visual reference
